-
Notifications
You must be signed in to change notification settings - Fork 6.3k
Prefer project-local .codex as CODEX_HOME; update docs (fixes #3706) #4007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
Thank you for this! Looking forward to it. |
15f45cf to
fa8199b
Compare
|
Merge this please, it's an essential piece of functionality. |
… directory sanitization
|
This two commit, extends the /status panel to display which codex_home the project is currently running with. Details
CODEX_HOME: ~/codex A folder named .codex was opened in the main project directory. |
|
github spec-kit asks you to set CODEX_HOME when using it in a project. This would make that unnessecary. |
|
@kervel Yes, that's true; the goal is to create a project-specific conf structure. Under normal use, if there's no .codex folder in the project, the system will work as before without any impact. |
|
The challenge with supporting an in-repo One could imagine a situation where someone tries to trick Codex into adding Today, with Seatbelt on macOS, we have the ability to make, e.g., the codex/codex-rs/core/src/seatbelt.rs Line 136 in 1e0e553
Though the Landlock/Seccomp sandbox we use on Linux does not support this today. My understanding is that it does not allow a subfolder ( All that is to say, before supporting such a feature, I think we need a reasonable mitigation for the scenario described above (be it sandboxing or in-repo |
|
Related: #2308. |
|
@cemilcolak, after some internal discussion, we've decided to close this PR. We really appreciate that you took the time to implement this. This is a highly-requested feature, and we'd love to get it into the hands of codex users. However, as bolinfest mentions above, the difficult part is in working through the security and sandboxing implications of the feature. That's going to require some deep thought and design work. Once we have those questions answered and the requisite sandboxing enhancements in place, it should be straightforward to implement the code to handle project-local features. We can use your code as a good PoC (proof of concept). |
|
@bolinfest @etraut-openai Thanks for the explanation. I’ve been using this feature for about 1.5 months and it’s been very helpful in practice. I understand your concerns, and I’ll also think more about the security side. I’m happy to help again once the design is ready. |
Motivation
compliance easier to reason about per project.
flags.
Testing
Manual sanity
Changed files
Notes